Fix potential buffer overflow issue #263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this issue while implementing a small resampler based on this project.
Description
AudioRenderer
andAudioOverlayFilter
use:to calculate the size of the target buffer.
In case this estimation is too small (happens on big differences in samplerate) this results in 2 issues.
Issue
processAudioFrame
inaudio-processor.cpp
doesn't know about the size, resulting in memory access vialoation.Fix
Drop audio when target buffer capacity is reached.
Issue
targetFrame.buffer.limit(targetBufferSize)
throws anIllegalArgumentException
.Fix
Take min
min(targetBufferSize, targetFrame.buffer.capacity())