Skip to content

Commit

Permalink
ignore e203 in flake8 to resolve black conflict (#25)
Browse files Browse the repository at this point in the history
## Summary
<!--- This is a required section; please describe the main purpose of
this proposed code change. --->

<!---
## Details
This is an optional section; is there anything specific that reviewers
should be aware of?
--->

checkstyle is failing on main because flake8 and black don't agree with
each other due to psf/black#1437. Ignore E203
as black readme suggests.

## Testing Done
<!--- This is a required section; please describe how this change was
tested. --->

<!-- 
Complete the following tasks before sending your PR, and replace `[ ]`
with
`[x]` to indicate you have done them. 
-->

- [ ] run `make test` to ensure correctness
- [x] run `make checkstyle` to ensure code style
```
jobuser [ ~/Liger-Kernel ]$ make checkstyle
flake8 .; flake8_status=$?; \
isort .; isort_status=$?; \
black .; black_status=$?; \
if [ $flake8_status -ne 0 ] || [ $isort_status -ne 0 ] || [ $black_status -ne 0 ]; then \
        exit 1; \
fi
Skipped 1 files
All done! ✨ 🍰 ✨
45 files left unchanged.
```
- [ ] run `make test-convergence` to ensure convergence
  • Loading branch information
ByronHsu authored Aug 15, 2024
1 parent 2dc738d commit ee0ede6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ exclude =
.git,
__pycache__,
benchmark_internal/others
extend-ignore=E501,B006,E731,A002
# E203: https://github.com/psf/black/issues/315
extend-ignore=E501,B006,E731,A002,E203

0 comments on commit ee0ede6

Please sign in to comment.