Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gemma lightning example for single L40 GPU #120

Merged
merged 11 commits into from
Aug 28, 2024

Conversation

qingquansong
Copy link
Collaborator

@qingquansong qingquansong commented Aug 27, 2024

Summary

Add gemma lightning example for single L40 GPU

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@qingquansong qingquansong marked this pull request as draft August 27, 2024 17:03
@qingquansong qingquansong changed the title Add gemma lightning example for single L40 GPU [WIP]Add gemma lightning example for single L40 GPU Aug 27, 2024
@qingquansong
Copy link
Collaborator Author

@yundai424 @ByronHsu Waiting for #111 to check in and then can patch fused CE to test memory

@yundai424
Copy link
Collaborator

@qingquansong do you think if we should just replace llama with gemma2 in this lightning example, and fix the config so that it works with L40 GPU, just to minimize the code 🤔 -- and the example can be used out of the box as lightning studio example

@qingquansong
Copy link
Collaborator Author

qingquansong commented Aug 27, 2024

@qingquansong do you think if we should just replace llama with gemma2 in this lightning example, and fix the config so that it works with L40 GPU, just to minimize the code 🤔 -- and the example can be used out of the box as lightning studio example

SG! Or maybe set the default one to be Gemma and provide a llama example in readme with config changes? (basically wanna keep the small changes (tokenizer and fsdp) to support llama in the pro lightning testing

@qingquansong qingquansong marked this pull request as ready for review August 27, 2024 23:28
@qingquansong qingquansong changed the title [WIP]Add gemma lightning example for single L40 GPU Add gemma lightning example for single L40 GPU Aug 27, 2024
@qingquansong qingquansong merged commit 8089f1e into main Aug 28, 2024
2 checks passed
@qingquansong qingquansong deleted the qsong/gemma_lightning branch August 28, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants