Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Add pyproject.toml #150

Merged
merged 6 commits into from
Sep 3, 2024
Merged

[BUILD] Add pyproject.toml #150

merged 6 commits into from
Sep 3, 2024

Conversation

AndreSlavescu
Copy link
Contributor

Summary

added pyproject.toml

Testing Done

ran pip install -e . and it built successfully

  • Hardware Type: RTX 3090
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

ByronHsu
ByronHsu reviewed Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@ByronHsu ByronHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we try delete setup.py see if that works

pyproject.toml Outdated Show resolved Hide resolved
ByronHsu
ByronHsu reviewed Aug 28, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@ByronHsu
Copy link
Collaborator

ByronHsu commented Aug 31, 2024 •
edited
Loading

lgtm if we bump to the new ver, also transformers ver

@ByronHsu
Copy link
Collaborator

ByronHsu commented Sep 3, 2024

@AndreSlavescu let's get this in sometimes

ByronHsu
ByronHsu previously approved these changes Sep 3, 2024
View reviewed changes
@ByronHsu ByronHsu merged commit d338f4b into linkedin:main Sep 3, 2024
2 checks passed
@shimizust shimizust mentioned this pull request Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu ByronHsu approved these changes

@yundai424 yundai424 yundai424 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreSlavescu @ByronHsu @yundai424