-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CI workflow with checkstyle job #27
Conversation
- name: Set up Python | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: '3.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we use 3.10 here or 3.11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.10 should be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.10 matches our current dev environment so I think we can keep it as is for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
- name: Set up Python | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: '3.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.10 should be good
## Summary - Added CI workflow with checkstyle job ## Testing Done Tested locally with: `act pull_request -W .github/workflows/ci.yml` ``` [CI Pipeline/checkstyle] ✅ Success - Main Install dependencies [CI Pipeline/checkstyle] ⭐ Run Main Run checkstyle [CI Pipeline/checkstyle] 🐳 docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/3] user= workdir= | flake8 .; flake8_status=$?; \ | isort .; isort_status=$?; \ | black .; black_status=$?; \ | if [ $flake8_status -ne 0 ] || [ $isort_status -ne 0 ] || [ $black_status -ne 0 ]; then \ | exit 1; \ | fi | Skipped 1 files | All done! ✨ 🍰 ✨ | 45 files left unchanged. [CI Pipeline/checkstyle] ✅ Success - Main Run checkstyle [CI Pipeline/checkstyle] ⭐ Run Post Set up Python [CI Pipeline/checkstyle] 🐳 docker exec cmd=[/opt/acttoolcache/node/18.20.4/arm64/bin/node /var/run/act/actions/actions-setup-python@v3/dist/cache-save/index.js] user= workdir= [CI Pipeline/checkstyle] ✅ Success - Post Set up Python [CI Pipeline/checkstyle] Cleaning up container for job checkstyle [CI Pipeline/checkstyle] 🏁 Job succeeded ```
Summary
Testing Done
Tested locally with:
act pull_request -W .github/workflows/ci.yml