Added CI workflow with checkstyle job #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lancerts
reviewed
Aug 15, 2024
| - name: Set up Python | ||
| uses: actions/setup-python@v3 | ||
| with: | ||
| python-version: '3.10' |
There was a problem hiding this comment.
do we use 3.10 here or 3.11?
There was a problem hiding this comment.
3.10 matches our current dev environment so I think we can keep it as is for now
ByronHsu
approved these changes
Aug 15, 2024
| - name: Set up Python | ||
| uses: actions/setup-python@v3 | ||
| with: | ||
| python-version: '3.10' |
yundai424
pushed a commit
that referenced
this pull request
Aug 16, 2024
## Summary - Added CI workflow with checkstyle job ## Testing Done Tested locally with: `act pull_request -W .github/workflows/ci.yml` ``` [CI Pipeline/checkstyle] ✅ Success - Main Install dependencies [CI Pipeline/checkstyle] ⭐ Run Main Run checkstyle [CI Pipeline/checkstyle] 🐳 docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/3] user= workdir= | flake8 .; flake8_status=$?; \ | isort .; isort_status=$?; \ | black .; black_status=$?; \ | if [ $flake8_status -ne 0 ] || [ $isort_status -ne 0 ] || [ $black_status -ne 0 ]; then \ | exit 1; \ | fi | Skipped 1 files | All done! ✨ 🍰 ✨ | 45 files left unchanged. [CI Pipeline/checkstyle] ✅ Success - Main Run checkstyle [CI Pipeline/checkstyle] ⭐ Run Post Set up Python [CI Pipeline/checkstyle] 🐳 docker exec cmd=[/opt/acttoolcache/node/18.20.4/arm64/bin/node /var/run/act/actions/actions-setup-python@v3/dist/cache-save/index.js] user= workdir= [CI Pipeline/checkstyle] ✅ Success - Post Set up Python [CI Pipeline/checkstyle] Cleaning up container for job checkstyle [CI Pipeline/checkstyle] 🏁 Job succeeded ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Done
Tested locally with:
act pull_request -W .github/workflows/ci.yml