Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct fsdp act ckpt & redo benchmark #32

Merged
merged 3 commits into from
Aug 16, 2024
Merged

use correct fsdp act ckpt & redo benchmark #32

merged 3 commits into from
Aug 16, 2024

Conversation

ByronHsu
Copy link
Collaborator

@ByronHsu ByronHsu commented Aug 16, 2024

Summary

  1. switch to correct fsdp
  2. redo benchmark on top
  3. add efficiency callback
image

TODO: clean up the code & fix the path

Testing Done

  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence
jobuser [ ~/Liger-Kernel ]$ make checkstyle
flake8 .; flake8_status=$?; \
isort .; isort_status=$?; \
black .; black_status=$?; \
if [ $flake8_status -ne 0 ] || [ $isort_status -ne 0 ] || [ $black_status -ne 0 ]; then \
        exit 1; \
fi
Skipped 1 files
All done! ✨ 🍰 ✨
48 files left unchanged.

examples/huggingface/training.py Outdated Show resolved Hide resolved
examples/huggingface/img/hf_mem_alloc_2.png Outdated Show resolved Hide resolved
@yundai424 yundai424 merged commit 8d88214 into main Aug 16, 2024
1 check passed
@ByronHsu ByronHsu deleted the byhsu/hf-2 branch August 23, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants