Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TVD Loss Kernel #324

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add TVD Loss Kernel #324

wants to merge 4 commits into from
+503 −1

Conversation

saurabhkoshatwar
Copy link

@saurabhkoshatwar saurabhkoshatwar commented Oct 26, 2024 •
edited
Loading

Summary

Resolves #281. Implements the TVD (Total Variation Distance) kernel by computing both the loss and gradient in the forward pass.

Testing Done

Implemented tests to verify that the results of the forward and backward passes match the Torch implementation. Additionally, added a script to benchmark the memory usage and speed of the Liger implementation compared to Torch, with the results shown below.

tvd_speed

tvd_memory

  • Hardware Type: Nvidia H100 (80GB PCIe)
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@saurabhkoshatwar
Copy link
Author

saurabhkoshatwar commented Oct 26, 2024 •
edited
Loading

@ByronHsu @qingquansong @lancerts Please let me know if any changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu Awaiting requested review from ByronHsu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TVD (Total variation distance) Kernel
1 participant
@saurabhkoshatwar