Skip to content

Commit

Permalink
Adding operationCount metric in preparation to replace operationRate (#…
Browse files Browse the repository at this point in the history
…1336)

In order to record more accurate and time-wise precise request rates we're going to test using Count metric as opposed to Meter (which is an average of 1, 5 and 15 minute periods)
  • Loading branch information
Dmitry Nikiforov authored and cgtz committed Jan 6, 2020
1 parent c802113 commit b156f85
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public class RestRequestMetrics {

static final String OPERATION_RATE_SUFFIX = "Rate";
static final String OPERATION_ERROR_SUFFIX = "Error";
static final String OPERATION_COUNT_SUFFIX = "Count";

static final String UNSATISFIED_REQUEST_COUNT_SUFFIX = "UnsatisfiedRequestCount";
static final String SATISFIED_REQUEST_COUNT_SUFFIX = "SatisfiedRequestCount";
Expand All @@ -56,6 +57,7 @@ public class RestRequestMetrics {

final Meter operationRate;
final Counter operationError;
final Counter operationCount;
final Counter unsatisfiedRequestCount;
final Counter satisfiedRequestCount;

Expand Down Expand Up @@ -95,6 +97,7 @@ public RestRequestMetrics(Class ownerClass, String requestType, MetricRegistry m

operationRate = metricRegistry.meter(MetricRegistry.name(ownerClass, requestType + OPERATION_RATE_SUFFIX));
operationError = metricRegistry.counter(MetricRegistry.name(ownerClass, requestType + OPERATION_ERROR_SUFFIX));
operationCount = metricRegistry.counter(MetricRegistry.name(ownerClass, requestType + OPERATION_COUNT_SUFFIX));

unsatisfiedRequestCount =
metricRegistry.counter(MetricRegistry.name(ownerClass, requestType + UNSATISFIED_REQUEST_COUNT_SUFFIX));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ public void recordMetrics() {
if (metrics != null) {
if (metricsRecorded.compareAndSet(false, true)) {
metrics.operationRate.mark();
metrics.operationCount.inc();
metrics.nioRequestProcessingTimeInMs.update(nioMetricsTracker.requestProcessingTimeInMs.get());
metrics.nioResponseProcessingTimeInMs.update(nioMetricsTracker.responseProcessingTimeInMs.get());
metrics.nioRoundTripTimeInMs.update(nioMetricsTracker.roundTripTimeInMs);
Expand Down

0 comments on commit b156f85

Please sign in to comment.