Move id converter to router.deleteBlob #2907
Closed
+175
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SophieGuo410
force-pushed
the
Branch_support_delete_withIdConverter
branch
3 times, most recently
from
2dc936f
to
d261465
Compare
SophieGuo410
force-pushed
the
Branch_support_delete_withIdConverter
branch
from
d261465
to
ab0a10d
Compare
SophieGuo410
requested review from
justinlin-linkedin,
Arun-LinkedIn and
alyssaxu333
alyssaxu333
approved these changes
Oct 7, 2024
| String blobIdStr = | ||
| removeLeadingSlashIfNeeded(restRequest.getArgs().get(RestUtils.InternalKeys.BLOB_ID).toString()); | ||
| proceedWithDelete(blobIdStr, serviceId, callback, futureResult, quotaChargeCallback); | ||
| } else { |
There was a problem hiding this comment.
I am wondering if we can call idConverter.convert() all the time inside the router. For named blobs, it would return the converted blob ID. For regular blobs, it would remove leading slash. Then we wouldn't need if-else condition and removeLeadingSlashIfNeeded() method here. What do you think?
There was a problem hiding this comment.
Logic wise I think it's doable, but I just want to avoid unnecessary network calls to mysql database, that's why I set this internal header to differentiate diff scenarios.
There was a problem hiding this comment.
Hmm I think in our IdConverter logic, we only make calls to MySQL if it is named blobs. For regular blobs, it would just strip the slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.