[Coral-Trino] Fix substr start index issue #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wmoustafa can help have a review? Thanks |
jerryleooo
changed the title
|
@wmoustafa @findepi can have a look? |
ljfgem
reviewed
Aug 1, 2023
coral-trino/src/main/java/com/linkedin/coral/trino/rel2trino/CoralToTrinoSqlCallConverter.java
Outdated
Show resolved
Hide resolved
coral-trino/src/main/java/com/linkedin/coral/trino/rel2trino/CoralToTrinoSqlCallConverter.java
Show resolved
Hide resolved
coral-trino/src/test/java/com/linkedin/coral/trino/rel2trino/HiveToTrinoConverterTest.java
Show resolved
Hide resolved
|
And I think |
|
Thank @ljfgem for reviewing, I have fixed all the issues mentioned and added |
ljfgem
changed the title
|
@ljfgem Gentle reminder. |
|
@ljfgem is this pending anything or can we merge? |
|
@jerryleooo @ebyhr new version with the fix 2.2.23 has been released. Thanks for your contributions. |
aastha25
added a commit
to aastha25/coral
that referenced
this pull request
Feb 23, 2024
This reverts commit a51a0db.
aastha25
added a commit
that referenced
this pull request
Feb 23, 2024
KevinGe00
pushed a commit
to KevinGe00/coral
that referenced
this pull request
Feb 26, 2024
…inkedin#492) * Revert "[Coral-Trino] Fix substr start index issue (linkedin#434)" This reverts commit a51a0db. * upgrade version to publish * fix tests and stylecheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Fix #433
How was this patch tested?
Modify the existing unit tests accordingly.