[Coral-Schema] Support ROW_NUMBER() OVER WINDOW #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljfgem
approved these changes
Jul 19, 2023
coral-schema/src/main/java/com/linkedin/coral/schema/avro/RelToAvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
coral-schema/src/main/java/com/linkedin/coral/schema/avro/RelToAvroSchemaConverter.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Prior to this PR, Coral didn't support generating the avro schema for views with function
ROW_NUMBER()over a window.This PR adds the support by implementing
visitOver()in the RexShuttle:SchemaRexShuttle.Refer to
ViewToAvroSchemaConverterTests.testRowNumberOverWindow()for an example usage.How was this patch tested?
./gradlew spotlessApply
./gradlew build
added UT
tested the targeted production view on the gateway
i-tested against production views