Updating logs to improve debugging (#83)

* Updating logs to improve debugging --------- Co-authored-by: Avinash Kumar <avinkuma@linkedin.com>
linkedin · Jun 11, 2024 · 838aaf3 · 838aaf3
1 parent a764088
commit 838aaf3
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/cdi-core/src/main/java/com/linkedin/cdi/connection/HttpConnection.java b/cdi-core/src/main/java/com/linkedin/cdi/connection/HttpConnection.java
@@ -96,7 +96,7 @@ synchronized HttpClient getHttpClient(State state) {
         ConnectionClientFactory factory = (ConnectionClientFactory) factoryClass.newInstance();
         httpClient = factory.getHttpClient(state);
       } catch (Exception e) {
-        LOG.error("Error creating HttpClient: {}", e.getMessage());
+        LOG.error("Error creating HttpClient:", e);
       }
     }
     return httpClient;

diff --git a/cdi-core/src/main/java/com/linkedin/cdi/connection/JdbcConnection.java b/cdi-core/src/main/java/com/linkedin/cdi/connection/JdbcConnection.java
@@ -171,7 +171,7 @@ private WorkUnitStatus executeStatement(
       try {
         stmt.setFetchSize(jdbcSourceKeys.getPaginationInitValues().get(ParameterTypes.PAGESIZE).intValue());
       } catch (SQLException e) {
-        LOG.warn("not able to set fetch size");
+        LOG.error("Not able to fetch size: ", e);
       }
     }
 

diff --git a/cdi-core/src/main/java/com/linkedin/cdi/connection/S3Connection.java b/cdi-core/src/main/java/com/linkedin/cdi/connection/S3Connection.java
@@ -184,8 +184,9 @@ private ByteArrayInputStream handleUpload(Path path, String fileName) {
       return new ByteArrayInputStream(
               jsonObject.toString().getBytes(StandardCharsets.UTF_8)
       );
-    } catch (IOException e) {
-      LOG.error("Encountered IO Exception when reading from path: " + path, e);
+    } catch (Exception e) {
+      LOG.error("Encountered Exception when reading from path: {}", path);
+      LOG.error("Error ", e);
       return null;
     }
   }
@@ -243,7 +244,7 @@ synchronized S3Client getS3HttpClient(State state) {
                 .credentialsProvider(getCredentialsProvider(state))
                 .build();
       } catch (Exception e) {
-        LOG.error("Error creating S3 Client: {}", e.getMessage());
+        LOG.error("Error creating S3 Client", e);
       }
     }
     return s3Client;

diff --git a/cdi-core/src/main/java/com/linkedin/cdi/extractor/AvroExtractor.java b/cdi-core/src/main/java/com/linkedin/cdi/extractor/AvroExtractor.java
@@ -200,7 +200,7 @@ protected boolean processInputStream(long starting) {
             SchemaUtils.isValidSchemaDefinition(schemaColumns, fieldNames, jobKeys.getDerivedFields().size()));
       }
     } catch (Exception e) {
-      LOG.error("Source Error: {}", e.getMessage());
+      LOG.error("Source Error: ", e);
       state.setWorkingState(WorkUnitState.WorkingState.FAILED);
       return false;
     }

diff --git a/cdi-core/src/main/java/com/linkedin/cdi/factory/network/KeyCertRetriever.java b/cdi-core/src/main/java/com/linkedin/cdi/factory/network/KeyCertRetriever.java
@@ -58,6 +58,8 @@ public KeyCertRetriever(State state) {
       privateKey = Base64.getEncoder().encodeToString(entry.getPrivateKey().getEncoded());
       cert = Base64.getEncoder().encodeToString(entry.getCertificate().getEncoded());
     } catch (KeyStoreException | NoSuchAlgorithmException | CertificateException | UnrecoverableEntryException e) {
+      LOG.error("Error while loading key and cert for Alias : {}", keyAlias);
+      LOG.error("Error", e);
       throw new RuntimeException(e);
     }
   }