Skip to content

Commit

Permalink
[LI-HOTFIX] Remove CI on push and tests when creating a release (#379)
Browse files Browse the repository at this point in the history
TICKET = N/A
LI_DESCRIPTION =
1. I added the following rules to project the main branch 3.0-li
- Require a pull request before merging. Also Require approvals.
- Require status checks to pass before merging.
Thus we no longer need to trigger all tests when creating a release.

2. There is no need to trigger tests upon a push. So this PR also removes the push trigger.

EXIT_CRITERIA = N/A
  • Loading branch information
gitlw authored Aug 26, 2022
1 parent 62905d7 commit 4de9f63
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 16 deletions.
13 changes: 0 additions & 13 deletions .github/workflows/build-and-upload-archives-upon-creating-tags.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,11 @@ on:
- '*'

jobs:
code-analysis:
uses: ./.github/workflows/code-analysis.yml

unit-test:
uses: ./.github/workflows/unit-test.yml

int-test:
uses: ./.github/workflows/int-test.yml

publish:
# Name the Job
name: Build tagged commit and upload the artifacts
# Set the type of machine to run on
runs-on: ubuntu-latest
needs:
- code-analysis
- unit-test
- int-test
steps:
# Checks out a copy of your repository on the ubuntu-latest machine
- name: Checkout code
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/code-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ name: Code analysis
on:
workflow_call:
pull_request:
push:
# Using wildcard (e.g. '**') to build on all branches will cause PRs to run duplicate checks like `test (pull_request)` with `test (push)`.
branches:
- 3.0-li
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/int-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ name: intTest
on:
workflow_call:
pull_request:
push:
# Using wildcard (e.g. '**') to build on all branches will cause PRs to run duplicate checks like `test (pull_request)` with `test (push)`.
branches:
- 3.0-li
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ name: unitTest
on:
workflow_call:
pull_request:
push:
# Using wildcard (e.g. '**') to build on all branches will cause PRs to run duplicate checks like `test (pull_request)` with `test (push)`.
branches:
- 3.0-li
Expand Down

0 comments on commit 4de9f63

Please sign in to comment.