Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LI-CHERRY-PICK] LIKAFKA-59153: Adding throttling logs in consumer. #517

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Yellow-Rice
Copy link

@Yellow-Rice Yellow-Rice commented Jul 17, 2024

Summary

This cherry-pick is to add logs for consumer throttling. It is part of the LIKAFKA-59153 as a follow up task of ACTIONITEM-873 and Incident 641.

Tests

Executed FetchSessionHandlerTest.

./gradlew -Dorg.gradle.java.home=/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home clients:test --tests org.apache.kafka.clients.FetchSessionHandlerTest

Original Commit Message

When the consumer's fetch request is throttled by the KIP-219 mechanism, it receives an empty fetch response. The consumer should not log this as an error.

Reviewers: Jason Gustafson jason@confluent.io

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

When the consumer's fetch request is throttled by the KIP-219 mechanism,
it receives an empty fetch response.  The consumer should not log this
as an error.

Reviewers: Jason Gustafson <jason@confluent.io>
Copy link

@CCisGG CCisGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@Yellow-Rice Yellow-Rice merged commit 5f9845f into 2.4-li Jul 18, 2024
21 checks passed
@Yellow-Rice Yellow-Rice deleted the yy/fix-throttle-msg branch July 18, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants