Skip to content

Commit

Permalink
resolve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
brycezhongqing committed Oct 9, 2024
1 parent f727ff8 commit 5adcb9b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and what APIs have changed, if applicable.

## [29.58.12] - 2024-10-07
- Add support for announcing/deannoucing service only to INDIS

## [29.58.11] - 2024-10-03
- Add getters in ZookeeperAnnouncer

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* ConnectionManager is an abstract class responsible for managing connections to external systems.
* It can be extended to handle specific service registries (e.g., Zookeeper).
* For example, see {@link com.linkedin.d2.balancer.servers.ZooKeeperConnectionManager} for managing Zookeeper connections during D2 server announcements.
* This class provides basic functionalities such as start, shutdown, markDownAllServers, and markUpAllServers which
* is called during D2 server announcements/de-announcement.
*/
public abstract class ConnectionManager
{
private final ZooKeeperAnnouncer[] _servers;
Expand Down

0 comments on commit 5adcb9b

Please sign in to comment.