Skip to content

Commit

Permalink
Downgrade major version to 29
Browse files Browse the repository at this point in the history
Bumping the major version to 30 is technically the correct thing to do from a
semver perspective when a public API is removed. However, it also has a huge
impact that outweighs the API breakage in terms of propogating the change to
all consumers. We feel like this tradeoff is acceptable.
  • Loading branch information
zackthehuman committed Aug 25, 2023
1 parent 098516f commit cfef163
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ and what APIs have changed, if applicable.

## [Unreleased]

## [29.45.0] - 2023-08-25

- Downgrade major version back to 29. Technically this is not semver-compatible
but we feel that the impact should be less sever than the impact of bumping
the major version.

## [30.0.0] - 2023-08-15
- Remove resetTogglingStores functionality from LoadBalancerClientCli, which is incompatible with Java 17

Expand Down Expand Up @@ -5518,7 +5524,8 @@ patch operations can re-use these classes for generating patch messages.

## [0.14.1]

[Unreleased]: https://github.com/linkedin/rest.li/compare/v30.0.0...master
[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.45.0...master
[29.45.0]: https://github.com/linkedin/rest.li/compare/v30.0.0...v29.45.0
[30.0.0]: https://github.com/linkedin/rest.li/compare/v29.44.0...v30.0.0
[29.44.0]: https://github.com/linkedin/rest.li/compare/v29.43.11...v29.44.0
[29.43.11]: https://github.com/linkedin/rest.li/compare/v29.43.10...v29.43.11
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version=30.0.0
version=29.45.0
group=com.linkedin.pegasus
org.gradle.configureondemand=true
org.gradle.parallel=true
Expand Down

0 comments on commit cfef163

Please sign in to comment.