Skip to content

Commit

Permalink
resolve all the comments
Browse files Browse the repository at this point in the history
  • Loading branch information
brycezhongqing committed Sep 16, 2024
1 parent 03d42f1 commit e76e8bb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ and what APIs have changed, if applicable.
## [Unreleased]

## [29.58.7] - 2024-09-13
Add WildcardResourceSubscriber for restli-resource-explorer subscribe to all resources
- Add WildcardResourceSubscriber which could subscribe to all resources, like NODE and URIMap resources.

## [29.58.6] - 2024-09-08
- Allow for null paging inside Collection response envelopes
Expand Down
3 changes: 2 additions & 1 deletion d2/src/main/java/com/linkedin/d2/xds/XdsClientImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public class XdsClientImpl extends XdsClient
Arrays.stream(ResourceType.values())
.filter(e -> e.typeUrl() != null)
.collect(Collectors.toMap(Function.identity(), e -> new HashMap<>())));
private final Map<ResourceType, WildcardResourceSubscriber> _wildcardSubscribers = new HashMap<>();
private final Map<ResourceType, WildcardResourceSubscriber> _wildcardSubscribers = Maps.newEnumMap(ResourceType.class);
private final Node _node;
private final ManagedChannel _managedChannel;
private final ScheduledExecutorService _executorService;
Expand Down Expand Up @@ -861,6 +861,7 @@ public void run()
{
rewrittenType = type;
}
// If there is a wildcard subscriber, we should always send a wildcard request to the server.
if (getWildcardResourceSubscriber(type) != null)
{
resources.add("*");
Expand Down

0 comments on commit e76e8bb

Please sign in to comment.