Update grpc version to 1.59.1 and protobuf to 3.24.0 #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohhyang
reviewed
Jun 25, 2024
gradle.properties
Outdated
| @@ -1,4 +1,4 @@ | |||
| version=29.57.0 | |||
| version=29.57.1 | |||
There was a problem hiding this comment.
Please update the minor version (29.58.0) since this is a significant change.
There was a problem hiding this comment.
I don't think we're introducing any new feature in pegasus to bump minor version. pegasus features should ideally remain the same. since this is backward compatible major version bump is also not required.
|
Is this tested as a snapshot on some real apps? Please add testing info to the PR description, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update grpc version to 1.59.1 and protobuf to 3.24.0
gRPC changes with 1.59.0 https://groups.google.com/g/grpc-io/c/HdrAVplyw7U/m/ki4QQkwOAQAJ
ProtoBuf changes with 3.24.0 https://groups.google.com/g/protobuf/c/mbfAytlUapY/m/n6Ex9uscDAAJ
Tests: tested RC version in dataformats/grpc-infra wc-test.