updated PegasusPlugin to still register restModel tasks even if IDL files dir is empty #924
Conversation
| @@ -1991,10 +1991,6 @@ protected void configureRestClientGeneration(Project project, SourceSet sourceSe | |||
| { | |||
| // idl directory for api project | |||
| File idlDir = project.file(getIdlPath(project, sourceSet)); | |||
| if (SharedFileUtils.getSuffixedFiles(project, idlDir, IDL_FILE_SUFFIX).isEmpty()) | |||
| { | |||
| return; | |||
There was a problem hiding this comment.
will there be downsides for packing an empty jar?
why will you need a jar that is empty? Can your logic assume it empty when it doesn't exist?
There was a problem hiding this comment.
no downsides or compatibility issues. just some negligible space will be used for PDL only projects to publish empty jars.
We will never use the empty jar. only the jars with IDL/ restmodels will be used by clients.
There was a problem hiding this comment.
updated PR as per offline discussion @junchuanwang @mchen07
|
Discussed offline, so the empty jar published seems to be an unfortunate and inevitable side-effect if we use these changes to make these restModel tasks configured. Publishing empty jar should be backward compatible in restli sense. I give ship as we assessed this won't impact existing user. |
…iles dir is empty
gradle-plugins/src/main/java/com/linkedin/pegasus/gradle/PegasusPlugin.java
Outdated
Show resolved
Hide resolved
Details: Allow creating rest model gradle tasks even if there are no IDL files are present at project evaluation time if
rest.idl.processEmptyIdlDiris set to true for the project.###Testing Done
build