Set log level of dual read mode changes to info #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapaCharlie
approved these changes
Jul 25, 2023
d2/src/main/java/com/linkedin/d2/balancer/dualread/DualReadStateManager.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/balancer/dualread/DualReadStateManager.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/balancer/dualread/DualReadStateManager.java
Outdated
Show resolved
Hide resolved
bohhyang
force-pushed
the
bohan/setDualReadLogLevel
branch
from
ff92179
to
4c64654
Compare
PapaCharlie
approved these changes
Jul 25, 2023
ZoabKapoor
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Pilot testing INDIS read path, we need to avoid the extra step of manually setting the log level to debug on test host. Given that the dual read mode will change very infrequently (only at testing), we set the log level to info.