Fix logging issues about dual read mode #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoabKapoor
approved these changes
Aug 4, 2023
| } | ||
|
|
||
| public void updateCluster(String cluster, DualReadModeProvider.DualReadMode mode) | ||
| { | ||
| _clusterDualReadModes.put(cluster, mode); | ||
| LOG.info("Dual read mode for cluster {} updated: {}", cluster, mode); | ||
| DualReadModeProvider.DualReadMode oldMode = _clusterDualReadModes.put(cluster, mode); |
There was a problem hiding this comment.
:til:
I didn't know that Map.put returns the original value if it was there!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, the dual read mode is logged about being updated without checking whether it's really updated or just setting with the same existing value. Since cluster dual read mode depends on incoming requests to trigger an update when d2 services under that cluster is called, the cluster dual read mode is logged on every request.
Changes
List<EquivalentAddressGroup> servers = resolutionResult.getAddresses(); channelLogger.log(ChannelLogLevel.INFO, "Address resolved: {0}", servers);Tests Done
QEI deployment with toki