Remove reset toggling stores option in LoadBalancerClientCli to remove Java 17 incompatible code #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoabKapoor
force-pushed
the
java_17_compat
branch
from
b073b0e
to
b4653ef
Compare
|
LGTM. Technically, we are not planning to "upgrade restli to Java 17". Instead, we want to make restli compatible with Java 17. So probably we can rephrase the PR description to make it more explicit. |
nizarm
previously requested changes
Aug 15, 2023
d2/src/main/java/com/linkedin/d2/balancer/util/LoadBalancerClientCli.java
Show resolved
Hide resolved
…e Java 17 incompatible code
ZoabKapoor
force-pushed
the
java_17_compat
branch
from
b4653ef
to
f16c2a5
Compare
ZoabKapoor
added
the
backward-incompatible
ZoabKapoor
temporarily deployed
to
jfrog-publish
GitHub Actions
Inactive
|
Btw, I've created a release candidate for this so we can wc-test it: https://github.com/linkedin/rest.li/actions/runs/5895056039 |
ZoabKapoor
force-pushed
the
java_17_compat
branch
from
a81d15f
to
f16c2a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to allow us make restli compatible with Java 17. The only functionality that's removed is the ability to
resetTogglingStoresfrom theLoadBalancerClientCli, which is unused elsewhere in the codebase.This change is needed for #929