Fix ByteBuffer errors to be compatible with Java 8 runtimes #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackthehuman
requested changes
Sep 27, 2023
JoeJoe1989
force-pushed
the
yanzhou/bytebuffer_error
branch
from
92fe986
to
24827f6
Compare
JoeJoe1989
changed the title
zackthehuman
approved these changes
Sep 27, 2023
zackthehuman
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The root cause is that, after compiling ResLi in Java 11, the new Java 11 implementation was preferred over the Java 8 implementation. However, since the new implementation was introduced after Java 8, a NoSuchMethodError occurred for Java 8 consumers. To resolve the issue, we chose an implementation that exists in both Java 8 and Java 11.
Changes
This PR will apply the same fix to URIDecoderUtils.java as was done in the prior PR to URIDecoderUtils.java.
Tests Done
Followed the instructions provided by the team who reported the issue and tested locally using curli command.