simplify symlink subscription in xds flow #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapaCharlie
reviewed
Oct 4, 2023
d2/src/main/java/com/linkedin/d2/xds/XdsToD2PropertiesAdaptor.java
Outdated
Show resolved
Hide resolved
PapaCharlie
approved these changes
Oct 4, 2023
shivamgupta1
reviewed
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current Observer only has a symlink for cluster config /d2/clusters/$xxxMaster, but not a counterpart symlink for uri parent /d2/uris/$xxxMaster. In fact, since cluster symlink and uri parent symlink always point to the same actual node name, and it's a redundancy and a burden for the symlink-update tool to maintain two symlinks for the same actual node name.
We optimize xds flow to use the cluster symlink to listen to the actual nodes for both cluster and uri parent.
Once all apps migrate off ZK flow, we don't need to maintain the uri parent symlink anymore.
Test Done
updated unit tests.