Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildlib: set a proper name when creating a github release #1524

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

buildlib: set a proper name when creating a github release #1524

wants to merge 1 commit into from

Conversation

nmorey
Copy link
Contributor

@nmorey nmorey commented Nov 19, 2024

By default, AZP creates a release on Github names vXX.YY which does not match the format currently used: rdma-core-XX.YY This changes the release name to match the expected format.

Fixes: 936cf8e ("build/azp: Have Azure Pipelines create releases when tags are made")

@rleon
Copy link
Member

rleon commented Nov 19, 2024

Are you sure that this is a fix?
I see that releases are named properly rdma-core-XX.YY, which is done manually.

@nmorey
Copy link
Contributor Author

nmorey commented Nov 19, 2024

Yes I've renamed all the hundreds of stable releases manually in GH. IIRC we had proper GH names when using Travis but I could never get it to work with AZP for some reason.
The fixes is to be sure that this get picked on the stable branches but I can remove the Fixes tag if you don't like it

@rleon
Copy link
Member

rleon commented Nov 19, 2024

Maybe these names didn't work for stable, but for main release, I always wrote full rdma-core-XX.YY name and never saw incorrect name.

I don't mind regarding Fixes, just trying to understand if I should take it now or wait after release (in next two weeks).

@nmorey
Copy link
Contributor Author

nmorey commented Nov 19, 2024

OK my bad, the commit message is slightly off.
Right now, there is no release title set by AZP (and not vXX.YY).
This commit simply sets it to the proper value automatically. I'll reword that

@nmorey
buildlib: set a proper name when creating a github release
ea39370 
By default, AZP creates a release on Github without any name.
This patch set a release name with the format rdma-core-XX.YY

Signed-off-by: Nicolas Morey <nmorey@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmorey @rleon