Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbuild: Avoid permission denied error due to SElinux #986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rleon
Copy link
Member

@rleon rleon commented Apr 20, 2021

When using SELinux for controlling processes within a container,
we need to make sure any content that gets volume mounted into
the container is readable.

Use :Z option for volume mounts, so docker will set correct labels.

This change fixes the error below:
➜ rdma-core git:(master) buildlib/cbuild make centos7
CMake Error: The source directory "/home/leonro/src/rdma-core" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
....

Signed-off-by: Leon Romanovsky leonro@nvidia.com

When using SELinux for controlling processes within a container,
we need to make  sure any content that gets volume mounted into
the container is readable.

Use :Z option for volume mounts, so docker will set correct labels.

This change fixes the error below:
➜  rdma-core git:(master) buildlib/cbuild make centos7
CMake Error: The source directory "/home/leonro/src/rdma-core" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
....

Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
@jgunthorpe
Copy link
Member

Why doesn't /tmp need a label? I'm not sure about this, doesn't re-labeling mean the filesystem is changed?

@rleon
Copy link
Member Author

rleon commented Apr 20, 2021

I tried with /tmp and it didn't accept ":Z", my explanation is that it is not part of SElinux.

And it is not relabeling but actually call to the following command inside docker:
chcon -Rt svirt_sandbox_file_t -l s0:c1,c2 /path/to/dir
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux_atomic_host/7/html/container_security_guide/docker_selinux_security_policy

@jgunthorpe
Copy link
Member

Doesn't that command change the filesystem? Does this work on non-selinux systems? I wonder if we should just give up and make this stuff use podman

@rleon
Copy link
Member Author

rleon commented Apr 20, 2021

Doesn't that command change the filesystem? Does this work on non-selinux systems? I wonder if we should just give up and make this stuff use podman

I don't know about other OSes, but on my plain FC 33 cbuild doesn't work.

@jgunthorpe
Copy link
Member

I'm not really sure about this, it touches the filesystem to write the labels.. This is why people turn selinux off

@rleon
Copy link
Member Author

rleon commented Apr 21, 2021

ok, I disabled SElinux and it fixed permission error.

Let's keep this PR maybe more people will complain, because disabling SElinux is not a solution but a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants