[Fix] Updated packages required by the discogs plugin for beets 2.0+ (on the stable branch) #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bot, here are the test results for this PR:
|
aptalca
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is identical to #125 except it targets the master/stable builds of docker-beets.
With it merged, #120 can finally be closed.
With the release of Beets 2.0 around 4 months ago, the required python package needed for the Discogs plugin has been changed. As a result, the builds of Beets in this container spit out an error message upon each album import. The details of this are outlined in #120
As stated in the official documentation for the Discogs plugin, the previous required package for Discogs plugin support (
discogs-client) has been deprecated and superseded bypython3-discogs-client. In order forpython3-discogs-clientto work as intended and not cause Beets to crash withModuleNotFoundError: No module named 'typing_extensions'upon invocation, the packagetyping-extensionshas also been added to the pip install command in both Dockerfiles.Benefits of this PR and context:
This patch, along with another that targets the stable branch, closes #120, eliminating the error message mentioned in that bug report and furthering working Discogs metadata support for the foreseeable future.
How Has This Been Tested?
The changes in this PR have been tested by locally building the container on my Ubuntu 24.04.1 LTS server and running it with Docker version 27.2.0. The webUI was tested for functionality and, using the CLI interface, multiple albums were imported and edited with my personal Beets configuration file that makes use of the Discogs plugin. All systems functioned as expected sans the aforementioned error.
Source / References: