Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add a format script based on prettier #874

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

paulfouquet
Copy link
Collaborator

Motivation

Before pushing some changes, I want my modifications to have a correct format based on the LINZ prettier config.

Modification

Add a format script that can be run manually using npm run format

Checklist

  • Tests updated N/A
  • Docs updated N/A
  • Issue linked in Title N/A

package.json Outdated Show resolved Hide resolved
Co-authored-by: Victor Engmark <vengmark@linz.govt.nz>
@paulfouquet paulfouquet requested a review from l0b0 February 18, 2024 23:01
@paulfouquet
Copy link
Collaborator Author

There are a couple of issues with prettier 🤔

  • not adding the newline at the end of the files
  • in github actions workflows, ${{env.MY_VAR}} should be formatted to ${{ env.MY_VAR }}, but it's not

@paulfouquet paulfouquet marked this pull request as draft February 18, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants