Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): use in-memory SQLite databases for testing where possible #2080

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

provinzkraut
Copy link
Member

Refactor test that use SQLite (SQLAlchemy / piccolo) to use an in-memory SQLite database instead of a file

sourcery-ai bot and others added 2 commits July 28, 2023 10:15
…sible (Sourcery refactored) (#2081)

'Refactored by Sourcery'

Co-authored-by: Sourcery AI <>
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2080

Copy link
Member

@JacobCoffee JacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing from docs is wild to me

@provinzkraut
Copy link
Member Author

Importing from docs is wild to me

You mean the test-testing things? I don't like it either, but the examples are already tests, so it kinda makes sense that we just run those.

@provinzkraut provinzkraut enabled auto-merge (squash) July 28, 2023 14:51
@provinzkraut provinzkraut merged commit acc5848 into main Jul 28, 2023
18 checks passed
@provinzkraut provinzkraut deleted the refactor-sqlite-tests branch July 28, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants