Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v1.51): #1948 passing wrapper class to struct logging config causes pydantic exception #2105

Merged
merged 2 commits into from
Aug 4, 2023
Merged

fix(v1.51): #1948 passing wrapper class to struct logging config causes pydantic exception #2105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b4ede4
fix: resolve issue with non method members on protocol
JacobCoffee Aug 2, 2023
b5f9ff1
infra: add CODEOWNERS to 1.51 branch
JacobCoffee Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Code owner settings for `litestar`
# @maintainers should be assigned to all reviews.
# Most specific assignment takes precedence though, so if you add a more specific thing than the `*` glob, you must also add @maintainers
# For more info about code owners see https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-file-example

# Global Assignment
* @litestar-org/maintainers @litestar-org/members

# Documentation
docs/* @litestar-org/maintainers @JacobCoffee @provinzkraut
2 changes: 1 addition & 1 deletion starlite/config/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ class StructLoggingConfig(BaseLoggingConfig, BaseModel):

processors: Optional[List[Processor]] = Field(default_factory=default_structlog_processors) # pyright: ignore
"""Iterable of structlog logging processors."""
wrapper_class: Optional[Type[BindableLogger]] = Field(default_factory=default_wrapper_class) # pyright: ignore
wrapper_class: Any = Field(default_factory=default_wrapper_class) # pyright: ignore
"""Structlog bindable logger."""
context_class: Optional[Dict[str, Any]] = None
"""Context class (a 'contextvar' context) for the logger."""
Expand Down
Loading