test(sqla repo): unify UUID and BigInt tests (Sourcery refactored) #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if repository_pk_type == "uuid": | ||
| return models_uuid | ||
| return models_bigint | ||
| return models_uuid if repository_pk_type == "uuid" else models_bigint |
There was a problem hiding this comment.
Function repository_module refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-598
to
+599
| author.books.append(book_model(title="Testing")) | ||
| else: | ||
| author = cast(models_bigint.BigIntAuthor, author) | ||
| book_model = cast("type[models_bigint.BigIntBook]", book_model) | ||
| author.books.append(book_model(title="Testing")) | ||
|
|
||
| author.books.append(book_model(title="Testing")) |
There was a problem hiding this comment.
Function test_repo_created_updated refactored with the following changes:
- Hoist repeated code outside conditional statement (
hoist-statement-from-if)
provinzkraut
added a commit
that referenced
this pull request
Aug 3, 2023
* test(sqla repo): unify UUID and BigInt tests * test(sqla repo): rename test_repo_uuid.py > test_repository.py * test(sqla repo): fix typing for 3.8 * test(sqla repo): fix typing * feat: test stringified and raw IDs * test: address review comments and do some refactoring * Revert "feat: test stringified and raw IDs" This reverts commit 512e454 * test(sqla repo): unify UUID and BigInt tests (Sourcery refactored) (#2108) 'Refactored by Sourcery' Co-authored-by: Sourcery AI <> * test: fix typing that sourcery broke --------- Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #2093 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
sqla-testsbranch, then run:Help us improve this pull request!