meson: add ability to configure libsrtp2 crypto library (defaulting to mbedtls) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iameli
force-pushed
the
eli/srtp-mbedtls
branch
from
34181cb
to
e1338af
Compare
iameli
force-pushed
the
eli/srtp-mbedtls
branch
from
45f96a4
to
1be1b95
Compare
victorges
approved these changes
Dec 7, 2023
| @@ -24,4 +24,4 @@ option('WITH_JPG', description: 'Build JPG thumbnailer output support (WIP)', ty | |||
| option('WITH_SANITY', description: 'Enable MistOutSanityCheck output for testing purposes', type: 'boolean', value: false) | |||
| option('LSP_MINIFY', description: 'Try to minify LSP JS via java closure-compiler, generally not needed unless changing JS code as a minified version is part of the repository already', type: 'boolean', value: false) | |||
| option('LOCAL_GENERATORS', description: 'Attempts to find a locally-installed version of sourcery and make_html, instead of compiling it', type: 'boolean', value: false) | |||
|
|
|||
| option('SRTP_CRYPTO_LIBRARY', type: 'combo', choices : ['none', 'openssl', 'nss', 'mbedtls'], value : 'mbedtls', description : 'What external crypto library to leverage for libsrtp2, if any (OpenSSL, NSS, or mbedtls)') | |||
There was a problem hiding this comment.
is this configured somewhere? or is mbedtls the default?
There was a problem hiding this comment.
Yeah this part makes it the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was upstreamed to cisco/libsrtp2 so now it's very easy. cisco/libsrtp#660
Preliminary testing showed similar performance for OpenSSL and mbedtls, and mbedtls is already a Meson subproject, so we may as well just use this. Both OpenSSL and mbedtls were around twice as performant as the built-in libsrtp2 crypto functions.