Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onnx] Lowerings from onnx.selu #2634

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[onnx] Lowerings from onnx.selu #2634

merged 1 commit into from
Dec 14, 2023

Conversation

rsuderman
Copy link
Contributor

@rsuderman rsuderman commented Dec 12, 2023 •
edited
Loading

Lowerings for selu lowerings for ONNX to the corresponding torch implementations.
Torch has no selu implementation and instead uses a generalize elu with the input scale
set to 1.0.

This was referenced Dec 12, 2023
Closed
Closed
@saienduri
Copy link
Collaborator

Hi Rob, onnx.relu lowering has already been addressed here: #2601. We are using this issue to monitor which ops have already been taken/implemented: nod-ai/SHARK-ModelDev#215.

@rsuderman
Copy link
Contributor Author

Hi Rob, onnx.relu lowering has already been addressed here: #2601. We are using this issue to monitor which ops have already been taken/implemented: nod-ai/SHARK-Turbine#215.

Sounds good, I can remove. We should probably avoid checking off implementations before landing a PR and mark as in progress with a issue / username. It makes it a bit tricky when working on grouped operations.

@rsuderman rsuderman changed the title [onnx] Lowerings from onnx.relu and onnx.selu [onnx] Lowerings from onnx.selu Dec 13, 2023
@rsuderman rsuderman mentioned this pull request Dec 14, 2023
Closed
@rsuderman
[onnx] Lowerings from onnx.selu
ac485bd 
Started work on the `selu` lowerings for ONNX to Torch.
vivekkhandelwal1
vivekkhandelwal1 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsuderman rsuderman merged commit 4857606 into llvm:main Dec 14, 2023
5 checks passed
@rsuderman rsuderman deleted the ReluSElu branch December 14, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-s-john wu-s-john wu-s-john approved these changes

@vivekkhandelwal1 vivekkhandelwal1 vivekkhandelwal1 approved these changes

@stellaraccident stellaraccident Awaiting requested review from stellaraccident

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsuderman @saienduri @wu-s-john @vivekkhandelwal1