[MLIR][ONNX] Add support for onnx.scan op #3516
Conversation
Shukla-Gaurav
force-pushed
the
gaurav/scanop
branch
2 times, most recently
from
39fe0ae
to
8d7cde2
Compare
|
Might be a good idea to either run an e2eshark op test or a custom test case with a contrived graph "loop body" just to make sure this actually runs and is consistent with onnxruntime. Sometimes the PrimLoopOp lowers to linalg but IREE is unable to execute it due to problems with mutability in tensors. |
Shukla-Gaurav
force-pushed
the
gaurav/scanop
branch
2 times, most recently
from
ec91723
to
6140c09
Compare
Shukla-Gaurav
force-pushed
the
gaurav/scanop
branch
2 times, most recently
from
81ca1ff
to
9df0e29
Compare
This commit lowers onnx.scan op to torch.prim.Loop op and adds the lowering in the onnx pipeline. Signed-Off-by: Gaurav Shukla <gaurav.shukla@amd.com>
Shukla-Gaurav
force-pushed
the
gaurav/scanop
branch
from
9df0e29
to
4faba0c
Compare
Thanks @renxida for pointing out this. I am tracking the e2e test case here: nod-ai/SHARK-TestSuite#276 |
|
@vivekkhandelwal1 @renxida can you please re-review and let me know if this looks good? |
This commit lowers onnx.scan op to torch.prim.Loop op and adds the lowering in the onnx pipeline. Signed-off-by: Gaurav Shukla <gaurav.shukla@amd.com>
This commit lowers onnx.scan op to torch.prim.Loop op and adds the lowering in the onnx pipeline.