Revert commits causing release build failure #3699
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patel-vimal
changed the title
|
Hi @patel-vimal, can you please update this PR as per the discussion on the original PR? |
Sure. Instead of reverting the changes, I'll drop only the changes which are now redundant. |
`get_int64_max` and `get_int64_min` was introduced in TorchMLIRModule to get int64 min/max from C++ standard library and use it as Integer +inf and -inf. However, the fx_importer now uses torch.iinfo() to get these values and hence these definitions can be dropped.
patel-vimal
force-pushed
the
vimal/revert_fx_importer_for_int_infinity
branch
from
64652cc
to
75d8807
Compare
Updated this PR to only undo the unnecessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits are reverted:
(1) 2960538
(2) fa39d91
The release build is failing and the 2nd commit is suspected to be the reason. Some of the changes in this commit are unnecessary and must be dropped while reapplying. The 1st commit fixes some of the changes made in the 2nd commit and therefore the 1st commit is also reverted. It could be reapplied along with the 2nd one later on.
cc: @vivekkhandelwal1