Refactor: Extract pushToDataLayer to standalone and tested module

lmc-eu · Oct 21, 2024 · 63659a4 · 63659a4
1 parent 9cad93a
commit 63659a4
Show file tree

Hide file tree

Showing 6 changed files with 433 additions and 20 deletions.
diff --git a/config/jest.config.json b/config/jest.config.json
@@ -12,5 +12,6 @@
     "/node_modules/",
     "/dist/"
   ],
+  "testEnvironment": "jsdom",
   "modulePathIgnorePatterns": ["<rootDir>/dist"]
 }
diff --git a/package.json b/package.json
@@ -103,6 +103,7 @@
     "eslint-plugin-prettier": "5.2.1",
     "husky": "9.1.6",
     "jest": "29.7.0",
+    "jest-environment-jsdom": "29.7.0",
     "nodemon": "3.1.7",
     "npm-run-all2": "6.2.3",
     "postcss": "8.4.47",

diff --git a/src/LmcCookieConsentManager.ts b/src/LmcCookieConsentManager.ts
@@ -11,6 +11,7 @@ import {
 } from './types';
 import { CookieConsentCategory, DisplayMode, SecondaryButtonMode } from './constants';
 import { assembleLanguagesConfig } from './languages/loader';
+import { pushToDataLayer } from './dataLayer';
 
 /* eslint-disable-next-line no-unused-vars, @typescript-eslint/no-empty-function */
 const noopAcceptCallback: OnAcceptCallback = (cookieConsent) => {};
@@ -167,17 +168,4 @@ const LmcCookieConsentManager: CookieConsentManager = (serviceName, args) => {
   return cookieConsent;
 };
 
-function pushToDataLayer(cookie: VanillaCookieConsent.Cookie<CookieConsentCategoryValues>) {
-  window.dataLayer = window.dataLayer || [];
-  window.dataLayer.push({
-    event: 'CookieConsent-update',
-    'CookieConsent.necessary': cookie.level.includes(CookieConsentCategory.NECESSARY),
-    'CookieConsent.analytics': cookie.level.includes(CookieConsentCategory.ANALYTICS),
-    'CookieConsent.ad': cookie.level.includes(CookieConsentCategory.AD),
-    'CookieConsent.functionality': cookie.level.includes(CookieConsentCategory.FUNCTIONALITY),
-    'CookieConsent.personalization': cookie.level.includes(CookieConsentCategory.PERSONALIZATION),
-    'CookieConsent.revision': cookie.revision,
-  });
-}
-
 export { CookieConsentCategory, DisplayMode, SecondaryButtonMode, VanillaCookieConsent, LmcCookieConsentManager };
diff --git a/src/__tests__/dataLayer.test.ts b/src/__tests__/dataLayer.test.ts
@@ -0,0 +1,62 @@
+import { pushToDataLayer } from '../dataLayer';
+import { CookieConsentCategoryValues, VanillaCookieConsent } from '../types';
+import { CookieConsentCategory } from '../constants';
+
+describe('dataLayer', () => {
+  describe('pushToDataLayer', () => {
+    it('should pushToDataLayer', () => {
+      expect(true).toBe(true);
+    });
+
+    beforeEach(() => {
+      // Reset the dataLayer before each test
+      window.dataLayer = [];
+    });
+
+    it('should push the correct event to the dataLayer', () => {
+      const cookie: VanillaCookieConsent.Cookie<CookieConsentCategoryValues> = {
+        level: [CookieConsentCategory.NECESSARY, CookieConsentCategory.ANALYTICS],
+        data: { uid: '123', serviceName: 'foo-service' },
+        revision: 1,
+        rfc_cookie: true,
+      };
+
+      pushToDataLayer(cookie);
+
+      expect(window.dataLayer).toEqual([
+        {
+          event: 'CookieConsent-update',
+          'CookieConsent.necessary': true,
+          'CookieConsent.analytics': true,
+          'CookieConsent.ad': false,
+          'CookieConsent.functionality': false,
+          'CookieConsent.personalization': false,
+          'CookieConsent.revision': 1,
+        },
+      ]);
+    });
+
+    it('should handle empty levels correctly', () => {
+      const cookie: VanillaCookieConsent.Cookie<CookieConsentCategoryValues> = {
+        level: [],
+        data: { uid: '123', serviceName: 'foo-service' },
+        revision: 333,
+        rfc_cookie: true,
+      };
+
+      pushToDataLayer(cookie);
+
+      expect(window.dataLayer).toEqual([
+        {
+          event: 'CookieConsent-update',
+          'CookieConsent.necessary': false,
+          'CookieConsent.analytics': false,
+          'CookieConsent.ad': false,
+          'CookieConsent.functionality': false,
+          'CookieConsent.personalization': false,
+          'CookieConsent.revision': 333,
+        },
+      ]);
+    });
+  });
+});
diff --git a/src/dataLayer.ts b/src/dataLayer.ts
@@ -0,0 +1,15 @@
+import { CookieConsentCategoryValues, VanillaCookieConsent } from './types';
+import { CookieConsentCategory } from './constants';
+
+export const pushToDataLayer = (cookie: VanillaCookieConsent.Cookie<CookieConsentCategoryValues>) => {
+  window.dataLayer = window.dataLayer || [];
+  window.dataLayer.push({
+    event: 'CookieConsent-update',
+    'CookieConsent.necessary': cookie.level.includes(CookieConsentCategory.NECESSARY),
+    'CookieConsent.analytics': cookie.level.includes(CookieConsentCategory.ANALYTICS),
+    'CookieConsent.ad': cookie.level.includes(CookieConsentCategory.AD),
+    'CookieConsent.functionality': cookie.level.includes(CookieConsentCategory.FUNCTIONALITY),
+    'CookieConsent.personalization': cookie.level.includes(CookieConsentCategory.PERSONALIZATION),
+    'CookieConsent.revision': cookie.revision,
+  });
+};