Skip to content

Commit

Permalink
Style(web): Fix selector order and undefined check in Toast component
Browse files Browse the repository at this point in the history
  • Loading branch information
literat committed Oct 17, 2024
1 parent 5c5c147 commit 33d2629
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/web/src/js/Toast.ts
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class Toast extends BaseComponent {
if (linkContent) {
const linkElementWithType = document.createElement(linkProps.elementType || 'a');
linkElement.replaceWith(linkElementWithType);
const isUnderlined = linkProps.isUnderlined !== undefined ? linkProps.isUnderlined : true;
const isUnderlined = linkProps.isUnderlined != null ? linkProps.isUnderlined : true;

linkElementWithType.classList.add('ToastBar__link');
if (isUnderlined) {
Expand Down
10 changes: 5 additions & 5 deletions packages/web/src/scss/components/TextField/_TextField.scss
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ $_field-name: 'TextField';
}

// 6.
.TextField__passwordToggle > .TextField__input:focus-visible,
.TextField__passwordToggle__button:focus-visible {
outline: 0;
}

.TextField__input:hover + .TextField__passwordToggle__button {
background-color: form-fields-theme.$input-background-color-hover;
}
Expand Down Expand Up @@ -146,11 +151,6 @@ $_field-name: 'TextField';
}
// stylelint-enable selector-max-specificity, selector-max-class, selector-max-compound-selectors

.TextField__passwordToggle > .TextField__input:focus-visible,
.TextField__passwordToggle__button:focus-visible {
outline: 0;
}

// 9.
.TextField__passwordToggle__button:focus-visible::after {
content: '';
Expand Down

0 comments on commit 33d2629

Please sign in to comment.