Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC(web-react, web-twig): elementType in Heading #DS-1482 #1691

Merged

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Oct 8, 2024

Description

Additional context

Issue reference

Set default element type for Heading component

@github-actions github-actions bot added the BC Breaking change label Oct 8, 2024
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 73683c0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/670ccbc0b501f800085392e5

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 73683c0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/670ccbc0e5cdbf0008afb7bc
😎 Deploy Preview https://deploy-preview-1691--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 83 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Oct 8, 2024

Coverage Status

coverage: 78.795% (+0.01%) from 78.782%
when pulling 73683c0 on BC/ds-1482-heading-element-type
into 852b0e6 on integration/BC-v3-design-tokens.

@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Copy link
Contributor

github-actions bot commented Oct 9, 2024

@pavelklibani pavelklibani force-pushed the BC/ds-1482-heading-element-type branch from 2ba406c to fbb95dc Compare October 9, 2024 18:29
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/web-react/src/types/heading.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 👍

@pavelklibani pavelklibani changed the title BREAKING-CHANGE(web-react, web-twig): elementType in Heading BC(web-react, web-twig): elementType in Heading #DS-1482 Oct 10, 2024
@pavelklibani pavelklibani force-pushed the BC/ds-1482-heading-element-type branch from d5bdc74 to 73683c0 Compare October 14, 2024 07:43
@pavelklibani pavelklibani merged commit fa00d88 into integration/BC-v3-design-tokens Oct 14, 2024
29 checks passed
@pavelklibani pavelklibani deleted the BC/ds-1482-heading-element-type branch October 14, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants