Fix(web-react): FileUploaderInput className #DS-1508 #1719
+178
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
curdaj
commented
Oct 17, 2024
There was a problem hiding this comment.
Only for DEMO... will be removed
curdaj
commented
Oct 17, 2024
There was a problem hiding this comment.
Only for DEMO... will be removed
crishpeen
approved these changes
Oct 17, 2024
literat
reviewed
Oct 18, 2024
| const [ids, register] = useAriaIds(ariaDescribedBy); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Are we able to test this?
There was a problem hiding this comment.
It would be nice to have 2 tests. One for CSR where event listeners like onDragOver, etc. are set, and one for SSR where there are undefined. :-)
There was a problem hiding this comment.
I'm sorry, but I still can't figure out how to test it :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference