Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarified docs, errors, and warnings #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

siennathesane
Copy link
Contributor

Small change to make the config easier to understand.

Signed-off-by: Sienna Lloyd sienna@linux.com

Signed-off-by: Sienna Lloyd <sienna@linux.com>
@lni
Copy link
Owner

lni commented Oct 28, 2022

Thanks for the PR, but the change seems to be incorrect -

when RTTMillisecond is 100 milliseconds and the election interval is expected to be 1 second, ElectionRTT should be 10.

@siennathesane
Copy link
Contributor Author

Is ElectionRTT a multiplier or a length of time? I can make the change, I just want to make sure I understand it.

@siennathesane
Copy link
Contributor Author

@lni would you be able to provide clarification on my previous question?

@coufalja
Copy link
Contributor

Even though I am not @lni I think I can answer your question: ElectionRTT and HeartbeatRTT are both multipliers of RTTMillisecond.

@lni
Copy link
Owner

lni commented Dec 28, 2022

@coufalja is correct.

@mxplusb I had a quick look at the godoc in config/config.go, there are concrete examples on the definitions of both ElectionRTT and HeartbeatRTT. Would you like to have a look and provide feedback on whether it is still a little bit difficult to understand. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants