Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure CMG is equipped when burning delay and pre-charge it for subsequent days. #1373

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

Malibu-Stacey
Copy link
Member

@Malibu-Stacey Malibu-Stacey commented Oct 13, 2023

Description

Fixing a minor issue with delay burning using the CMG. I checked my log from my current run to see how it was handling using the 8bit zones to burn delay & noticed it failed to fight a void monster 3 times in a row in Vanya's Castle. Once the bonus zone changed to Megalo-City it equipped the CMG correctly & fought the void monster.
This change forces the CMG to be equipped in the off-hand slot when burning delay fighting a free void monster rather than relying on the maximizers weighting.

I also added a small change to when the CMG is equipped to charge it as we can pre-charge it for the next day when we still have delay to burn.

How Has This Been Tested?

Hasn't yet. My test account is in Small but has finished day 1. I'll have it run day 2 after rollover then start a new day 1 to verify it's all as expected.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based my pull request against the main branch or have a good reason not to.

@Malibu-Stacey Malibu-Stacey added the bug Something isn't working label Oct 13, 2023
@Malibu-Stacey Malibu-Stacey requested review from a team October 13, 2023 21:30
@Malibu-Stacey Malibu-Stacey self-assigned this Oct 13, 2023
Copy link
Member

@Alium58 Alium58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me as long as your testing goes well. Assuming it will so approving, but please finish testing before merging

@Malibu-Stacey
Copy link
Member Author

looks good to me as long as your testing goes well. Assuming it will so approving, but please finish testing before merging

Testing is all good. Finished day 1 in a new Normal Small run.
image

Previous run it placed 3 void monsters in delay zones on day 2 & finished the run before a 4th use was charged.

@Malibu-Stacey Malibu-Stacey merged commit 1cff4fd into main Oct 16, 2023
2 checks passed
@Malibu-Stacey Malibu-Stacey deleted the cmg_fix branch October 16, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants