Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

โœจ feat: Add changelog modal #4800

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

โœจ feat: Add changelog modal #4800

wants to merge 12 commits into from
+2,490 โˆ’153

Conversation

canisminor1990
Copy link
Member

@canisminor1990 canisminor1990 commented Nov 26, 2024 •
edited
Loading

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

image

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-database โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Dec 18, 2024 2:33am
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Dec 18, 2024 2:33am

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 26, 2024
@lobehubbot
Copy link
Member

๐Ÿ‘ @canisminor1990

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added the ๐ŸŒ  Feature Request New feature or request | ็‰นๆ€งไธŽๅปบ่ฎฎ label Nov 26, 2024
arvinxx
arvinxx reviewed Nov 26, 2024
View reviewed changes
src/app/(main)/_layout/Desktop.tsx Outdated Show resolved Hide resolved
src/services/changelog.ts Outdated

import { Locales } from '@/locales/resources';

const BASE_URL = 'https://raw.githubusercontent.com';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

่ฟ™ไธชไผšๅฏผ่‡ดๅชๆœ‰็”จๆˆท้‚ฃ่พน็ฟปๅข™ไบ†ๆ‰่ƒฝ็œ‹ๅˆฐ changelog๏ผŒๆ„Ÿ่ง‰่ฟ™ไธช่ฏทๆฑ‚้€ป่พ‘ๅบ”่ฏฅ่ฆๅšไธ€ไปฝๅˆฐ server ๅŽป่ฏทๆฑ‚ใ€‚่ตฐ edge ็š„ trpc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ๅคดๅ›พไนŸๆœ‰่ฟ™ไธช้—ฎ้ข˜

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

้‚ฃๅคดๅ›พๆ˜ฏไธๆ˜ฏๅบ”่ฏฅ่ตฐไธ€้“ไธŠไผ ๏ผŒ่ฝฌๅˆฐr2้‡ŒๅŽป๏ผŸ

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.26316% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.97%. Comparing base (679211d) to head (b3ff20f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/server/services/changelog/index.ts 95.48% 7 Missing โš ๏ธ
src/services/global.ts 83.33% 1 Missing โš ๏ธ
src/store/global/action.ts 80.00% 1 Missing โš ๏ธ
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4800      +/-   ##
==========================================
+ Coverage   91.95%   91.97%   +0.01%     
==========================================
  Files         548      548              
  Lines       41423    41558     +135     
  Branches     2511     2533      +22     
==========================================
+ Hits        38091    38221     +130     
- Misses       3332     3337       +5
Flag Coverage ฮ”
app 91.97% <95.26%> (+0.01%) โฌ†๏ธ
server 98.14% <รธ> (+0.01%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@arvinxx arvinxx force-pushed the feat/changelog-modal branch from 37a185a to 49430c4 Compare December 1, 2024 09:20
@arvinxx arvinxx force-pushed the feat/changelog-modal branch from 1689ecf to 0186714 Compare December 17, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvinxx arvinxx Awaiting requested review from arvinxx

Assignees
No one assigned
Labels
๐ŸŒ  Feature Request New feature or request | ็‰นๆ€งไธŽๅปบ่ฎฎ size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canisminor1990 @lobehubbot @arvinxx