Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update artifacts GitHub actions to v4 #43

Merged
merged 8 commits into from
Dec 4, 2024
Merged

update artifacts GitHub actions to v4 #43

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bed5a9f
update artifacts GitHub actions to v4
alexrashed Nov 8, 2024
6770aaa
fix issue with non-unique artifact ID
alexrashed Nov 19, 2024
f0de04c
update finish action to download separate artifact incase of pr previews
lukqw Dec 4, 2024
697cbd5
update smoke test suite for ephemeral instances
lukqw Dec 4, 2024
fb37edc
add assertion which checks for preview comment
lukqw Dec 4, 2024
6ecd579
add gh token
lukqw Dec 4, 2024
a84276f
failure case check
lukqw Dec 4, 2024
a118c9c
make tests green again
lukqw Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ephemeral/shutdown/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ runs:
using: composite
steps:
- name: Download PR artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: pr
name: pr-id

- name: Load the PR ID
id: pr
Expand Down
8 changes: 4 additions & 4 deletions ephemeral/startup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ runs:
}

- name: Download PR artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: pr
name: pr-id

- name: Setup preview name
shell: bash
Expand Down Expand Up @@ -102,9 +102,9 @@ runs:
echo "AWS_ENDPOINT_URL=$endpointUrl" >> $GITHUB_ENV

- name: Upload preview instance URL
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pr
name: preview-instance-url
lukqw marked this conversation as resolved.
Show resolved Hide resolved
path: ./ls-preview-url.txt

- name: Run preview deployment
Expand Down
6 changes: 3 additions & 3 deletions finish/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@ runs:
# Try to get pr artifact from current workflow
- name: Download current PR artifact
id: get-pr-artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
continue-on-error: true
with:
name: pr
name: pr-id

# If the above fails, try to get the latest pr artifact from the PR related workflows
- name: Download latest PR artifact
uses: dawidd6/action-download-artifact@v6
lukqw marked this conversation as resolved.
Show resolved Hide resolved
if: ${{ steps.get-pr-artifact.outcome == 'failure' }}
with:
name: pr
name: pr-id
pr: ${{ github.event.pull_request.number }}
# Can be ID or workflow file name, if empty falls back to the latest successful run of the current workflow
workflow: ${{ env.PR_ARTIFACT_WORKFLOW }}
lukqw marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
4 changes: 2 additions & 2 deletions local/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ runs:
- name: Download current workflow's Local State artifact
id: get-state-artifact
if: ${{ inputs.action == 'load' }}
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
continue-on-error: true
with:
name: ${{ inputs.name }}
Expand Down Expand Up @@ -48,7 +48,7 @@ runs:
ACTION: "${{ inputs.action }}"

- name: Upload LocalStack State
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ inputs.action == 'save' }}
with:
name: ${{ inputs.name }}
Expand Down
4 changes: 2 additions & 2 deletions prepare/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ runs:
run: echo ${{ github.event.number }} > ./pr-id.txt

- name: Upload PR number
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pr
name: pr-id
path: ./pr-id.txt

- name: Create initial PR comment
Expand Down
Loading