AP-5015 update bullmq metrics plugin to use redis configs instead of redis instances #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjamrog
requested review from
kibertoad,
CarlosGamero,
drdaemos and
a team
as code owners
kibertoad
reviewed
Aug 30, 2024
kibertoad
approved these changes
Aug 30, 2024
CarlosGamero
deleted the
AP-5015_update_bullmq_metrics_plugin_to_use_redis_config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context: https://lokalise.atlassian.net/browse/AP-5015
Updates
bullMqMetricsPluginto operate on RedisConfigs instead of Redis instances, so that the default parameters are injected before creating an instanceChecklist
major,minor,patchorskip-release