Skip to content

Commit

Permalink
Adding wasSuccessful param to TransactionObservabilityManager (#155)
Browse files Browse the repository at this point in the history
* Adding new wasSuccessful optional param to TransactionObservabilityManager

* Lint fix

* Preventing more lint issues on package.json after auto-release
  • Loading branch information
CarlosGamero authored Aug 29, 2024
1 parent 02d9272 commit 56097fd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
9 changes: 3 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@
"url": "git://github.com/lokalise/node-core.git"
},
"license": "Apache-2.0",
"files": [
"dist/**",
"LICENSE",
"README.md"
],
"files": ["dist/**", "LICENSE", "README.md"],
"main": "dist/index.js",
"types": "dist/index.d.ts",
"type": "commonjs",
Expand All @@ -31,7 +27,8 @@
"lint": "biome check . && tsc --project tsconfig.lint.json --noEmit",
"lint:fix": "biome check --write",
"version": "auto-changelog -p && git add CHANGELOG.md",
"prepublishOnly": "npm run build"
"prepublishOnly": "npm run build",
"postversion": "biome check --write package.json"
},
"dependencies": {
"dot-prop": "6.0.1",
Expand Down
3 changes: 2 additions & 1 deletion src/observability/observabilityTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export type TransactionObservabilityManager = {
/**
* Ends the transaction
* @param uniqueTransactionKey - used for identifying specific ongoing transaction. Must be reasonably unique to reduce possibility of collisions
* @param wasSuccessful - indicates if the transaction was successful or not
*/
stop: (uniqueTransactionKey: string) => unknown
stop: (uniqueTransactionKey: string, wasSuccessful?: boolean) => unknown
}

0 comments on commit 56097fd

Please sign in to comment.