feat: improve setting error name

lokalise · Aug 21, 2024 · 6b10ffb · 6b10ffb
1 parent cada3d4
commit 6b10ffb
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/errors/InternalError.spec.ts b/src/errors/InternalError.spec.ts
@@ -24,7 +24,6 @@ describe('InternalError', () => {
             message: 'Unknown',
             errorCode: 'INTERNAL_ERROR',
           })
-          this.name = 'ExtendedInternalError'
         }
       }
       const err = new ExtendedInternalError()

diff --git a/src/errors/InternalError.ts b/src/errors/InternalError.ts
@@ -20,7 +20,8 @@ export class InternalError<T = ErrorDetails> extends Error {
     super(params.message, {
       cause: params.cause,
     })
-    this.name = 'InternalError'
+    // set the name as the class name for every class that extends InternalError
+    this.name = this.constructor.name
     this.details = params.details
     this.errorCode = params.errorCode
   }

diff --git a/src/errors/PublicNonRecoverableError.spec.ts b/src/errors/PublicNonRecoverableError.spec.ts
@@ -33,7 +33,6 @@ describe('PublicNonRecoverableError', () => {
             message: 'Unknown',
             errorCode: 'PUBLIC_ERROR',
           })
-          this.name = 'ExtendedPublicNonRecoverableError'
         }
       }
       const err = new ExtendedPublicNonRecoverableError()

diff --git a/src/errors/PublicNonRecoverableError.ts b/src/errors/PublicNonRecoverableError.ts
@@ -25,7 +25,8 @@ export class PublicNonRecoverableError<T = ErrorDetails> extends Error {
     super(params.message, {
       cause: params.cause,
     })
-    this.name = 'PublicNonRecoverableError'
+    // set the name as the class name for every class that extends PublicNonRecoverableError
+    this.name = this.constructor.name
     this.details = params.details
     this.errorCode = params.errorCode
     this.httpStatusCode = params.httpStatusCode ?? 500