AP-5015 added maxRetriesPerRequest to RedisConfig #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjamrog
requested review from
kibertoad,
drdaemos,
CarlosGamero and
a team
as code owners
kibertoad
reviewed
Aug 30, 2024
kjamrog
commented
Aug 30, 2024
| @@ -13,6 +13,9 @@ export type RedisConfig = { | |||
| password?: string | |||
| commandTimeout?: number | |||
| connectTimeout?: number | |||
| maxRetriesPerRequest?: number | null | |||
| enableReadyCheck?: boolean | |||
| lazyConnect?: boolean | |||
There was a problem hiding this comment.
@kibertoad I added 2 more parameters that we are using in Flow, so that we are not blocked from using RedisConfig in cases when those are needed
kibertoad
approved these changes
Aug 30, 2024
kjamrog
deleted the
AP-5015_add_max_retries_per_request_to_redis_config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding maxRetriesPerRequest parameter to RedisConfig, so that it can be used in default configuration object.
See: https://lokalise.atlassian.net/browse/AP-5015
Checklist
major,minor,patchorskip-release