Add RetroAchievements plugin #1620
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request seems to be inactive and will be automatically closed in a few days if it remains without any activity. |
|
Not reviewed yet |
|
This pull request seems to be inactive and will be automatically closed in a few days if it remains without any activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created the RetroAchievements plugin for
metrics, using the RetroAchievements's official API.It follows the style and layout of the Steam plugin, and here it's what I have done so far. I'm opening the PR just to track the checks or feedback.
I've seen that
metricswill launch the 4.0 soon, but since there's no release date to it, the changes could be merged and I will do the migrations by my self when the new version's out, fixing any breaking changes and migrating other aspects to fit the new specs.Render output
This output was generated by my
metricsaction, using this brench as reference.Ready to merge?
metadata.ymlnameis set with an unused emoji and plugin namecategoryis set tocommunityexamplescontains links towards a rendered output hosted by youauthorscontains my GitHub usernamesupportslist which account type are supportedscopesare correctly listed with their associated names on GitHub (leave an empty array if not applicable)inputsare correctly filledindex.mjsrespects the plugins guidelinesshowachievementsisnoclassicis available)tests/mocks... have been createdapp.placeholder.jshas been updated for preview from web instancesexamples.ymlcontains workflows examples (at least one is required)skip: truehas been set forprodattribute in each testnpm run linteryields no errorsREADME.mdeventually describes complex setup or options (if applicable)