fix: subpath removal

lsegg · Oct 24, 2024 · 2e89ef7 · 2e89ef7
1 parent f53c1ce
commit 2e89ef7
Show file tree

Hide file tree

Showing 9 changed files with 28 additions and 32 deletions.
diff --git a/docs/assets/index-VBkLQ-qs.js → docs/assets/index-C8kJS1VA.js b/docs/assets/index-VBkLQ-qs.js → docs/assets/index-C8kJS1VA.js
diff --git a/docs/index.html b/docs/index.html
@@ -14,7 +14,7 @@
       rel="stylesheet"
       href="https://cdnjs.cloudflare.com/ajax/libs/animate.css/4.1.1/animate.min.css"
     />
-    <script type="module" crossorigin src="./assets/index-VBkLQ-qs.js"></script>
+    <script type="module" crossorigin src="./assets/index-C8kJS1VA.js"></script>
     <link rel="stylesheet" crossorigin href="./assets/index-DgD5xdTU.css" />
   </head>
   <body>

diff --git a/src/auth/pages/LoginPage.jsx b/src/auth/pages/LoginPage.jsx
@@ -7,8 +7,7 @@ export const LoginPage = () => {
   const navigate = useNavigate();
 
   const handleLogin = () => {
-    const lastPath =
-      localStorage.getItem("lastPath") || "/heroes-spa/home/search";
+    const lastPath = localStorage.getItem("lastPath") || "/home/search";
     login("Jane Doe");
     navigate(lastPath, { replace: true });
   };

diff --git a/src/heroes/components/HeroCard.jsx b/src/heroes/components/HeroCard.jsx
@@ -24,10 +24,7 @@ export const HeroCard = ({
               <p className="card-text">
                 <small className="text-muted">{first_appearance}</small>
               </p>
-              <Link
-                to={`/heroes-spa/home/hero/${id}`}
-                className="btn btn-outline-dark"
-              >
+              <Link to={`/home/hero/${id}`} className="btn btn-outline-dark">
                 More info
               </Link>
             </div>

diff --git a/src/heroes/pages/HeroPage.jsx b/src/heroes/pages/HeroPage.jsx
@@ -11,7 +11,7 @@ export const HeroPage = () => {
     navigate(-1);
   };
 
-  if (!hero) return <Navigate to="/heroes-spa/home" />;
+  if (!hero) return <Navigate to="/home" />;
   return (
     <div className="row mt-5">
       <div className="col-4">

diff --git a/src/router/AppRouter.jsx b/src/router/AppRouter.jsx
@@ -8,7 +8,7 @@ import { PublicRouter } from "./PublicRouter";
 
 const router = createHashRouter([
   {
-    path: "/heroes-spa",
+    path: "/",
     element: (
       <PublicRouter>
         <LoginPage />
@@ -17,7 +17,7 @@ const router = createHashRouter([
     errorElement: <ErrorPage />,
   },
   {
-    path: "/heroes-spa/home",
+    path: "home",
     element: (
       <PrivateRouter>
         <HeroesApp />
@@ -26,19 +26,19 @@ const router = createHashRouter([
     errorElement: <ErrorPage />,
     children: [
       {
-        path: "/heroes-spa/home/marvel",
+        path: "marvel",
         element: <MarvelPage />,
       },
       {
-        path: "/heroes-spa/home/dc",
+        path: "dc",
         element: <DcPage />,
       },
       {
-        path: "/heroes-spa/home/search",
+        path: "search",
         element: <SearchPage />,
       },
       {
-        path: "/heroes-spa/home/hero/:id",
+        path: "hero/:id",
         element: <HeroPage />,
       },
     ],

diff --git a/src/router/PrivateRouter.jsx b/src/router/PrivateRouter.jsx
@@ -9,5 +9,5 @@ export const PrivateRouter = ({ children }) => {
   const lastPath = pathname + search;
   localStorage.setItem("lastPath", lastPath);
 
-  return logged ? children : <Navigate to={"/heroes-spa/login"} />;
+  return logged ? children : <Navigate to={"/login"} />;
 };
diff --git a/src/router/PublicRouter.jsx b/src/router/PublicRouter.jsx
@@ -4,5 +4,5 @@ import { AuthContext } from "../auth";
 
 export const PublicRouter = ({ children }) => {
   const { logged } = useContext(AuthContext);
-  return !logged ? children : <Navigate to={"/heroes-spa/home/search"} />;
+  return !logged ? children : <Navigate to={"/home/search"} />;
 };
diff --git a/src/ui/components/NavBar.jsx b/src/ui/components/NavBar.jsx
@@ -7,13 +7,13 @@ export const NavBar = () => {
   const navigate = useNavigate();
   const handleLogout = () => {
     logout();
-    navigate("/heroes-spa", { replace: true });
+    navigate("/", { replace: true });
   };
 
   return (
     <nav className="navbar navbar-expand-lg navbar-dark bg-dark p-2">
       <div className="container-fluid">
-        <Link className="navbar-brand" to="/heroes-spa/home/search">
+        <Link className="navbar-brand" to="/home/search">
           Heroes
         </Link>
         <div className="collapse navbar-collapse" id="navbarNav">
@@ -22,23 +22,23 @@ export const NavBar = () => {
               className={({ isActive }) =>
                 `nav-link ${isActive ? "active" : ""}`
               }
-              to="/heroes-spa/home/marvel"
+              to="marvel"
             >
               Marvel
             </NavLink>
             <NavLink
               className={({ isActive }) =>
                 `nav-link ${isActive ? "active" : ""}`
               }
-              to="/heroes-spa/home/dc"
+              to="/home/dc"
             >
               DC
             </NavLink>
             <NavLink
               className={({ isActive }) =>
                 `nav-link ${isActive ? "active" : ""}`
               }
-              to="/heroes-spa/home/search"
+              to="/home/search"
             >
               Search
             </NavLink>