Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish as hex package #17

Open
sascha-wolf opened this issue May 14, 2019 · 5 comments
Open

Publish as hex package #17

sascha-wolf opened this issue May 14, 2019 · 5 comments
Assignees

Comments

@sascha-wolf
Copy link

I think this project would benefit from being published as a hex package.

IMO the current structure is not fully suited for publishing just yet. For example the global nature of the poller and matcher would make defining multiple bots impossible. As a solution it might make sense to consider an approach similar to an Ecto.Repo where configuration lives for a certain repo which then gets supervised and takes care of it's processes.

What do you think? I'm maintaining two small libs already so I would be happy to assist.

@lubien
Copy link
Owner

lubien commented May 14, 2019

I've actually started tinkering an pkg version of this app with some improvements over lessons learnt tho I don't think I can focus on this right now as I'm concurrently distributing time between some projects already.

But I can come back to this issue next month for sure.

@lubien lubien self-assigned this May 14, 2019
@sascha-wolf
Copy link
Author

If you do I think you should reconsider the send_message approach of spawning a task for each one.

Instead some kind of worker pool, for example using gen_stage, might be preferable.

HTTP connections are limited after all.

@lubien lubien mentioned this issue Jun 6, 2019
@v0idpwn
Copy link
Contributor

v0idpwn commented Sep 25, 2019

Hacktoberfest project, @lubien? 😀

@lubien
Copy link
Owner

lubien commented Sep 25, 2019

Hey that's a pretty good project. Wanna go for it?

@v0idpwn
Copy link
Contributor

v0idpwn commented Sep 26, 2019

I'll do the best I can, but I'm no expert. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants